pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/17718 )

Change subject: RLC/MAC: implement decoding of EGPRS Packet Channel Request
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h
File src/gsm_rlcmac.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/17718/2/src/gsm_rlcmac.h@5347
PS2, Line 5347: extern struct value_string egprs_pkt_ch_req_type_names[];
> Then we would also need to move EGPRS_PacketChannelRequestType_t, because 
> it's not going to make to  […]
Why isn't getting to wireshark? So nothoing of these new additions is going 
there? If everything's specific for us then it's fine keeping it as it is here 
at the end.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17718
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I96df3352856933c9140177b2801a2c71f4134183
Gerrit-Change-Number: 17718
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 21 May 2020 16:11:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilira...@gmail.com>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to