pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/18395 )

Change subject: Transceiver: Log when sending of CLK indications begins
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-trx/+/18395/2/Transceiver52M/Transceiver.cpp
File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/18395/2/Transceiver52M/Transceiver.cpp@1170
PS2, Line 1170:   if (!mForceClockInterface)
Let's not use this variable here. Move it to line 1056 in driveReceiveRadio. 
And by the way, you are applying the if codition wrong here, it's the opposite 
(mForceClockInterface is set to true at startup to force it being sent 
immediatelly.)



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18395
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6aa88943b76c9a2bf7aed60d6a3d325c1f27820a
Gerrit-Change-Number: 18395
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Fri, 22 May 2020 13:01:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to