pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/17423 )
Change subject: mgcp_protocol: Avoid code duplication between virtual + other trunks ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/17423/5/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/17423/5/src/libosmo-mgcp/mgcp_protocol.c@1669 PS5, Line 1669: llist_del(&cfg->virt_trunk->entry); > I agree, but i would argue to keep it like this for now since in patch #18372 > I have already address […] ACK, fine then if it's fixed soon. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/17423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I54762af6d417b849a24b6e71b6c5c996a5cb3fa6 Gerrit-Change-Number: 17423 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <[email protected]> Gerrit-Assignee: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 27 May 2020 12:36:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
