laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18035 )
Change subject: scheduler_trx: fix RSSI calculation for SUB frames ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/18035/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/18035/1/src/osmo-bts-trx/scheduler_trx.c@1281 PS1, Line 1281: RSSI_FR_LOWER_FOUR > The problem is that picking the measurement values becomes a lot more > difficult when I compute the a […] that kind of information is virtually impossible to gain by looking at the code - and also not by looking at the changelog. Hence, it is a prime example of what should be in a comment. Please add. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I902bb47d68742d2589156f61099b67a0edbaf40b Gerrit-Change-Number: 18035 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Thu, 28 May 2020 09:54:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <pma...@sysmocom.de> Comment-In-Reply-To: fixeria <axilira...@gmail.com> Gerrit-MessageType: comment
