pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18554 )
Change subject: *-mgw-*: support centos8 ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/docker-playground/+/18554/1/osmo-mgw-master/Dockerfile File osmo-mgw-master/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/18554/1/osmo-mgw-master/Dockerfile@5 PS1, Line 5: ARG DISTRO > Repeating DISTRO here is on purpose, ARG needs to be specified again after > FROM. Please leave a comment there saying that. https://gerrit.osmocom.org/c/docker-playground/+/18554/1/ttcn3-mgw-test/Dockerfile File ttcn3-mgw-test/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/18554/1/ttcn3-mgw-test/Dockerfile@5 PS1, Line 5: You don't need to set ARG here twice? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6579748056ce0505304378b342a698b98c77fd18 Gerrit-Change-Number: 18554 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 28 May 2020 15:29:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osm...@sysmocom.de> Gerrit-MessageType: comment
