pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370 )
Change subject: pcu: Refactor GPRS infrastructure to keep state and simplify tests ...................................................................... Patch Set 8: (4 comments) I'm fine with having lower layer APIs, but let's add low layer APIs which re-use data structures we have instead of having to pass parameters to them. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/8/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/8/pcu/GPRS_Components.ttcn@361 PS8, Line 361: f_pcuif_tx_data_ind(data, ms.lqual_cb, fn); So you are the one hating extra abstraction layers and you are re-adding one here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/8/pcu/GPRS_Components.ttcn@561 PS8, Line 561: function f_establish_tbf(out GsmRrMessage rr_imm_ass, So now we'll have 2 APIs doing similart stuff (establishing a UL TBF), f_establish_tbf and f_ms_establish_ul_tbf . Really? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/8/pcu/GPRS_Components.ttcn@591 PS8, Line 591: function f_pcuif_tx_data_ind(octetstring data, int16_t lqual_cb := 0, uint32_t fn := 0) I precisely wanted to get rid of these APIs where you stil labstract stuff but need to keep passing parameters every time. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/8/pcu/PCU_selftest.ttcn File pcu/PCU_selftest.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370/8/pcu/PCU_selftest.ttcn@294 PS8, Line 294: f_pcuif_tx_data_ind(data, 0, 0); What's wrong with usijng the MS APIs here? What if I want to test more complex stuff or APIs here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib3fee37580f0ea0530a659dec83656799bf57288 Gerrit-Change-Number: 18370 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2020 15:38:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
