srs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18536 )
Change subject: epc: add run function to EPC ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18536/2/src/osmo_gsm_tester/obj/epc.py File src/osmo_gsm_tester/obj/epc.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18536/2/src/osmo_gsm_tester/obj/epc.py@41 PS2, Line 41: self._run_node = run_node > self note: run node is actually part of this abstract class, so we should > move the registering of "r […] Sure. But I would consider this out of scope for this patch, no? -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Id86c61cbccd41b77f94f125d8d127e2ab5e46cd9 Gerrit-Change-Number: 18536 Gerrit-PatchSet: 2 Gerrit-Owner: srs_andre <an...@softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Reviewer: srs_andre <an...@softwareradiosystems.com> Gerrit-Comment-Date: Mon, 01 Jun 2020 08:22:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment