pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18372 )
Change subject: osmo-mgw: refactor endpoint and trunk handling ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/18372/6//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/18372/6//COMMIT_MSG@27 PS6, Line 27: efactor rate counters, put them into a separate module and do no : longer allocate them per trunk. Allocate them globally instead. > I'm not sure if this is a good idea. […] I think some of them were clearly meant at being global, so I think it's fine (I'm not saying all of them should be global). In any case I think it makes sense to have some of them global and we can later add it per trunk as needed after this clean up being done now. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice8aaf03faa2fd99074f8665eea3a696d30c5eb3 Gerrit-Change-Number: 18372 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Tue, 02 Jun 2020 10:50:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
