gui...@gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 )
Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 ...................................................................... Patch Set 5: (1 comment) > Patch Set 5: Verified+1 > > Build Successful > > https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/540/ : SUCCESS' > --verified 1 --code-review 0 I can test this in other Quectel modules, have quite a few :-) At the moment, using a BG96, which is where having the ability to read the SIM files is definitely useful for debugging https://gerrit.osmocom.org/c/pysim/+/18159/5/pySim/transport/modem_atcmd.py File pySim/transport/modem_atcmd.py: https://gerrit.osmocom.org/c/pysim/+/18159/5/pySim/transport/modem_atcmd.py@50 PS5, Line 50: if type(cmd) is str: there is a problem here if cmd is not a string, as it's not initiliased. I solved by doing by adding to this if else: bcmd = cmd.encode() Not sure if it's the right way to do it, though. Don't fully get why you used str.encode instead of cmd, I thought the purpouse of this was to turn the string into bytes? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: gui...@gmail.com <gui...@gmail.com> Gerrit-Comment-Date: Tue, 02 Jun 2020 12:55:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
