Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 )
Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 ...................................................................... Patch Set 5: > yes, I was running it with python 2, I thought it was not upgraded to 3. The > header of pySim-read still uses python2 :-) I fixed most of the problems like print without parentheses, so pySim works fine with Python 3 ;) Unfortunately, yes, we still have Python 2 in headers. The reason is that our test setup is based on old Debian image that ships ancient Python 3.5 from 2017 and old pyscard. Somehow this combination breaks our lazy 'match every line' unit tests. See https://gerrit.osmocom.org/c/pysim/+/15504/. > Still, if cmd is not a str, you will not initialise bcmd, so probably need to > add something in the else? Ah, I got what you mean now. Will try to fix soon. Thanks! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: gui...@gmail.com <gui...@gmail.com> Gerrit-Comment-Date: Tue, 02 Jun 2020 14:08:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
