laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18002 )
Change subject: lapd/lapdm: print user-defined string name instead of (dl=%p) ...................................................................... Patch Set 8: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/18002/8/src/gsm/lapd_core.c File src/gsm/lapd_core.c: https://gerrit.osmocom.org/c/libosmocore/+/18002/8/src/gsm/lapd_core.c@307 PS8, Line 307: dl->name = talloc_strdup(tall_lapd_ctx, name); > see my previous comment, don't you need osmo_talloc_replace() (or however > it's called) here? thanks. As we have two cases here, including one asprintf, I decided to go for a manual talloc_Free() above. https://gerrit.osmocom.org/c/libosmocore/+/18002/6/src/gsm/lapdm.c File src/gsm/lapdm.c: https://gerrit.osmocom.org/c/libosmocore/+/18002/6/src/gsm/lapdm.c@273 PS6, Line 273: lc->name = talloc_strdup(lc, name_pfx); > don't you need to free here if lc->name is already set? Because you are not > allocating lc here. […] Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be Gerrit-Change-Number: 18002 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 08 Jun 2020 19:13:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
