laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/18004 )
Change subject: Ensure we include lchan name in all LAPDm log lines
......................................................................
Ensure we include lchan name in all LAPDm log lines
This makes use of the newly-introduced lapdm_channel_init3() API,
which provides the user (BTS in this case) to provide a human-readable
string identifier for each LAPDm channel. This identifier is
subsequently used in all related log lines to provide context.
This means we will now get context information about which specific
SAPI in which sub-channel (ACCH/DCCH) on which lchan/ts/trx/bts a given
message originated from.
Example:
DLLAPD <0011> lapd_core.c:829 ((bts=0,trx=0,ts=0,ss=0)[DCCH][0]) SABM(E)
received in state LAPD_STATE_IDLE
Change-Id: I17e3d4797ec71e31d0775330ae36d2e1fd70423f
Depends: libosmocore.git Ie6742843fff809edffcac24c4dce4edf66bc71be
Related: OS#1938
---
A TODO-RELEASE
M src/common/bts.c
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/TODO-RELEASE b/TODO-RELEASE
new file mode 100644
index 0000000..1dd5e79
--- /dev/null
+++ b/TODO-RELEASE
@@ -0,0 +1 @@
+* update libosmocore dependency to > 1.3.x for lapdm_channel_init3()
diff --git a/src/common/bts.c b/src/common/bts.c
index 2200615..9710a2c 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -429,7 +429,8 @@
"Setting T200 D0=%u, D3=%u, S0=%u, S3=%u (all in
ms)\n",
t200_ms_dcch[DL_SAPI0], t200_ms_dcch[DL_SAPI3],
t200_ms_acch[DL_SAPI0], t200_ms_acch[DL_SAPI3]);
- lapdm_channel_init2(lc, LAPDM_MODE_BTS, t200_ms_dcch,
t200_ms_acch, lchan->type);
+ lapdm_channel_init3(lc, LAPDM_MODE_BTS, t200_ms_dcch,
t200_ms_acch, lchan->type,
+ gsm_lchan_name(lchan));
lapdm_channel_set_flags(lc, LAPDM_ENT_F_POLLING_ONLY);
lapdm_channel_set_l1(lc, NULL, lchan);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18004
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I17e3d4797ec71e31d0775330ae36d2e1fd70423f
Gerrit-Change-Number: 18004
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-MessageType: merged
