fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18833 )
Change subject: osmo-bts-trx: store pointer to gsm_lchan in l1sched_chan_state ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/18833/1/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/18833/1/src/common/scheduler.c@1005 PS1, Line 1005: chan_state->lchan = get_lchan_by_chan_nr(l1t->trx, chan_nr); > I se chan_state->lchan never set to NULL explicitly. […] We're using talloc_zero() everywhere, so it's set to NULL implicitly. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18833 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic4378020f980845b962f71b9e4b7faea738bc174 Gerrit-Change-Number: 18833 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 15 Jun 2020 15:09:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment