pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18837 )
Change subject: A-bis/OML: handle hopping params in Set Channel Attributes ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/18837/1/src/common/oml.c File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/18837/1/src/common/oml.c@889 PS1, Line 889: LOGPFOH(DOML, LOGL_NOTICE, foh, "SET CHAN ATTR: Frequency hopping not supported.\n"); NOTICE? ERROR better. Same below. https://gerrit.osmocom.org/c/osmo-bts/+/18837/1/src/common/oml.c@916 PS1, Line 916: ts->hopping.ma_len = TLVP_LEN(&tp, NM_ATT_ARFCN_LIST) / 2; probably using sizeof(int16_t) here and below instead of "2" makes it easier to understand why is that there (because they are 16bit values). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ieac26c7aca118c16889cdde2565a514681dc137b Gerrit-Change-Number: 18837 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 15 Jun 2020 15:16:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
