fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18835 )
Change subject: A-bis/RSL: refactor handling of BS Power IE (power reduction) ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/18835/1/include/osmo-bts/gsm_data_shared.h File include/osmo-bts/gsm_data_shared.h: https://gerrit.osmocom.org/c/osmo-bts/+/18835/1/include/osmo-bts/gsm_data_shared.h@269 PS1, Line 269: /* BTS power reduction (2 dB steps) */ > I think it makes more sense to keep it in dB internally, like we do for all > other power, pwr reducti […] ACK. https://gerrit.osmocom.org/c/osmo-bts/+/18835/1/src/common/tx_power.c File src/common/tx_power.c: https://gerrit.osmocom.org/c/osmo-bts/+/18835/1/src/common/tx_power.c@116 PS1, Line 116: int get_p_trxout_target_mdBm(struct gsm_bts_trx *trx, uint8_t bs_power_ie) I'll change it in the next patch set. > but not sure if this code is actually expecting 1dB unit instead 2db step. The code does * 2, so it's correct. I'll change it too. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18835 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I16cc50dfca102030380a06e16c234d5f6698f38f Gerrit-Change-Number: 18835 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 15 Jun 2020 15:52:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
