fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/18715 )
Change subject: use new osmo_mobile_identity API everywhere ...................................................................... Patch Set 6: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/18715/6/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/c/osmo-msc/+/18715/6/src/libmsc/gsm_04_08.c@156 PS6, Line 156: if (rc < 0) { So in this case we log "LOCATION UPDATE ACCEPT", but actually send nothing to subscriber. I think we need to log an error here, or just OSMO_ASSERT(). https://gerrit.osmocom.org/c/osmo-msc/+/18715/6/src/libmsc/gsm_04_08.c@224 PS6, Line 224: osmo_mobile_identity_to_str_c(OTC_SELECT, &mi)); Do we really need to allocate memory on heap here? Why not osmo_mobile_identity_to_str_buf()? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idfc8e576e10756aeaacf5569f6178068313eb7ea Gerrit-Change-Number: 18715 Gerrit-PatchSet: 6 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Fri, 19 Jun 2020 11:54:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
