pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19076 )
Change subject: pcu: Support sending with CS other than CS1 in f_ms_tx_ul_block() ...................................................................... Patch Set 2: > It does't make sense in a practical use case (i.e. an actual production > implementation). However, in a test tool, I think it does make sense to be > able to express such unusual (but legal!) situations. You can still do so (using whatever padding to simulate whatever CS you want) by using a lower-level API f_ms_tx_data_ind() as I do in TC_ul_data_toolong_fills_padding. I could, however, improve the function to pass CodingScheme cs:=omit and if omit is used, calculate automatically, otherwise calculate based on the cs passed (and error if not possible). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19076 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibafa4246b442e7c26666eb0d37570bfbbf1dbda7 Gerrit-Change-Number: 19076 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Thu, 02 Jul 2020 09:37:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
