neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19152 )

Change subject: bsc: add SI2quater tests for multiple EARFCNs
......................................................................


Patch Set 3:

> Patch Set 3: Code-Review-1
>
> Please use use template inheritance (see 'modifies' keyword [1]), so there 
> would be no need to define the same template with the same fields (with some 
> exceptions) again and again. See also [2]. In your case, incremental 
> inheritance should be possible, i.e. the template with 2 E-ARFCNs may be 
> inherited from the template with 1 E-ARFCN, the one with 3 E-ARFCNs may be 
> inherited from the old with 2 E-ARFCNs and so on.
>
> [1] ETSI ES 201 873-1, section 15.5 "Modified templates"
> [2] https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19114

ah yes I was planning on that but forgot when all the tests were nice and green 
:P


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19152
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I45382f88686ca60e68569e93569fc4cfb63a0e0d
Gerrit-Change-Number: 19152
Gerrit-PatchSet: 3
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Comment-Date: Mon, 06 Jul 2020 17:07:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to