laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18927 )
Change subject: manuals: generate vty reference xml at build time ...................................................................... Patch Set 3: Code-Review+1 > Patch Set 3: > > > You cannot fail if it doesn't match since you also get output from other > > git repositories in there (lib dependencies). > > true. > > I'm still for generating it automatically and not build the vty reference in > cross compilation. It's worth it to always have an up-to-date vty reference > and not drag outdated vtyref data along for ages in the git source tree > without anyone noticing. I can accept that (even though I dislike it). The questio is: Will this patch create fall-out? I guess not in the OBS builds, as they (even those for raspbian) are built "natively", and not cross-compiled. The sysmocom OE builds are cross-compiled. Might be worth checking if they disable the build of manuals before merging this. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I526af21134087e2b43b9ada59c93f636ae242e24 Gerrit-Change-Number: 18927 Gerrit-PatchSet: 3 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2020 10:35:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
