pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19287 )
Change subject: Move struct gsm_bts: gsm_data.* => bts.* ...................................................................... Patch Set 1: So I was starting to add new ACC barring/ramping code and I already run into hell when moving some bits from another file into gsm_bts_alloc() which is inside gsm_data.c and then I had to add gsm_data.o in Makefile to some files which in turn wanted to pull basically the whole project in... so this time (unlike previously with osmo-bts) I did this movement upfront to already help with the dependency hell created by having all in gsm_data making it difficult to put stuff there since all the model is a big fat block. I'm explaining this before anyone wants to start arguing whether this is really necessary or it helps... It Does. We do it for other objects, so more reason to do it for such an important one. I'm adding a lot of new includes: Yes, we already have plenty of them for other objects. Let's please go ahead and merge this, get code in a more maintainable fashion making it easier to add stuff into the data model by properly isolating objects instead of adding more churn to the big fat block. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I00c15f5285b5c1a0109279b7ab192d5467a04ece Gerrit-Change-Number: 19287 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 15 Jul 2020 19:08:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
