laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 )
Change subject: socket.c: add osmo_sockaddr_cmp() ...................................................................... Patch Set 7: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19415/7/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19415/7/src/socket.c@1589 PS7, Line 1589: /* fallback to memcmp for remaing AF */ : return memcmp(a, b, sizeof(struct osmo_sockaddr)); might be worth moving this into a "default:" clause of the switch statement to clearly see it's three different exist paths, rather than some coommon code at the end of the function. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2020 20:11:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
