lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19141 )
Change subject: socket.h: introduce osmo_sockaddr to hold v4 and v6 endpoints ...................................................................... Patch Set 8: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19141/1/include/osmocom/core/socket.h File include/osmocom/core/socket.h: https://gerrit.osmocom.org/c/libosmocore/+/19141/1/include/osmocom/core/socket.h@25 PS1, Line 25: struct osmo_sockaddr { > yes, I think it's universally the case that you always have a "sin_addr" / > "sin6_addr" / ... […] I don't think this is a problem. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If80172373735193401af872b18e1ff00c93880e7 Gerrit-Change-Number: 19141 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Sat, 01 Aug 2020 20:10:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
