lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19146 )
Change subject: gsm 12.21: add osmocom specific NM_ATT_OSMO_NS_LINK_CFG ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19146/7/src/gsm/abis_nm.c File src/gsm/abis_nm.c: https://gerrit.osmocom.org/c/libosmocore/+/19146/7/src/gsm/abis_nm.c@592 PS7, Line 592: TLV_TYPE_TL16V > Hmm, wouldn't TLV_TYPE_TV be enough BTW? no, it needs to be a tlv because the length isn't fixed. (the new ns_link_cfg can also support ipv4). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic261bc43a07fa741b97a9c6ec5a9ed6f5ecae588 Gerrit-Change-Number: 19146 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2020 08:54:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
