laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19524 )
Change subject: mgcp_e1: finish E1 support, add E1 support from libosmoabis ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/19524/2/src/libosmo-mgcp/mgcp_e1.c File src/libosmo-mgcp/mgcp_e1.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19524/2/src/libosmo-mgcp/mgcp_e1.c@57 PS2, Line 57: const ubit_t idle_tf_efr[] = { 0, 0, 0, 0, 0, 0, 0, 0, well, now it's const. But it shoud still be static, if it's only used within this file. static +const are not a contadiction... https://gerrit.osmocom.org/c/osmo-mgw/+/19524/2/src/libosmo-mgcp/mgcp_e1.c@142 PS2, Line 142: /* Idle speech frame, see also GSM 08.60, chapter 3.4 */ same as above. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6b93809b5ac7d01af55888347dd787b0bc997ae1 Gerrit-Change-Number: 19524 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Mon, 10 Aug 2020 20:06:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
