pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19142 )
Change subject: sockaddr_str: add osmo_sockaddr_str_from_str2() which doesn't set the port ...................................................................... Patch Set 10: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19142/10/src/sockaddr_str.c File src/sockaddr_str.c: https://gerrit.osmocom.org/c/libosmocore/+/19142/10/src/sockaddr_str.c@201 PS10, Line 201: if (!sockaddr_str) I would drop this check completely (for documentation as well), but ok. It makes no sense to call this function on a NULL pointer. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ifd4e282586b8bd40b912a9f1c25f9e8208420106 Gerrit-Change-Number: 19142 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2020 10:36:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
