pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19143 )
Change subject: socket: introduce osmo_sock_init3 & osmo_sock_init3_ofd ...................................................................... Patch Set 13: (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/19143/13/include/osmocom/core/socket.h File include/osmocom/core/socket.h: https://gerrit.osmocom.org/c/libosmocore/+/19143/13/include/osmocom/core/socket.h@61 PS13, Line 61: int osmo_sock_init3(uint16_t type, uint8_t proto, I don't really like calling this one osmo_sock_init3, since it's not really an upgrade from previous versions but rather a different function with different parameter, scope of use and logic, as lynxis explained in a previous comment. osmo_sock_init_sa() or similar looks like a better naming to me. https://gerrit.osmocom.org/c/libosmocore/+/19143/13/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19143/13/src/socket.c@465 PS13, Line 465: * This function creates a new socket of the designated \a family, \a No "family" parameter here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1eece543e3241ef0e095eb63bb831f7c15a16794 Gerrit-Change-Number: 19143 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2020 11:16:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
