pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/19641 )
Change subject: osmo-trx-ipc ...................................................................... Patch Set 10: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc-driver-test.c File Transceiver52M/device/ipc/ipc-driver-test.c: https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc-driver-test.c@245 PS10, Line 245: volatile bool ul_running = 0; = false https://gerrit.osmocom.org/c/osmo-trx/+/19641/10/Transceiver52M/device/ipc/ipc-driver-test.c@252 PS10, Line 252: pthread_setname_np(pthread_self(), "uplink_rx"); I was following CamelCase convention in osmo-trx because it uses less characters (only 15 allowed), but fine here for now. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/19641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ice63d3499026293ade8aad675ff7a883bcdd5756 Gerrit-Change-Number: 19641 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2020 15:40:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
