neels has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/19832 )


Change subject: CBC VTY: tweak VTY doc strings
......................................................................

CBC VTY: tweak VTY doc strings

Change-Id: I434835ae8dad9e726f296e648b1b55fb00be8ccb
---
M src/osmo-bsc/cbsp_link.c
1 file changed, 11 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/32/19832/1

diff --git a/src/osmo-bsc/cbsp_link.c b/src/osmo-bsc/cbsp_link.c
index d93bd1a..6a0884e 100644
--- a/src/osmo-bsc/cbsp_link.c
+++ b/src/osmo-bsc/cbsp_link.c
@@ -301,10 +301,11 @@
        return CMD_SUCCESS;
 }

+#define CBSP_REMOTE "Configure OsmoBSC as CBSP client towards a Cell Broadcast 
Centre (outbound TCP connection)\n"
+
 DEFUN(cfg_cbc_remote_ip, cfg_cbc_remote_ip_cmd,
        "remote-ip A.B.C.D",
-       "IP Address of the Cell Broadcast Centre\n"
-       "IP Address of the Cell Broadcast Centre\n")
+       CBSP_REMOTE "IP Address of the Cell Broadcast Centre\n")
 {
        struct bsc_cbc_link *cbc = vty_cbc_data(vty);
        osmo_talloc_replace_string(cbc, &cbc->config.cbc_hostname, argv[0]);
@@ -312,7 +313,7 @@
 }
 DEFUN(cfg_cbc_no_remote_ip, cfg_cbc_no_remote_ip_cmd,
        "no remote-ip",
-       NO_STR "Remove IP address of CBC; disables outbound CBSP connections\n")
+       NO_STR "Disable the CBSP client mode, disable outbound CBSP 
connections\n")
 {
        struct bsc_cbc_link *cbc = vty_cbc_data(vty);
        talloc_free(cbc->config.cbc_hostname);
@@ -322,17 +323,19 @@

 DEFUN(cfg_cbc_remote_port, cfg_cbc_remote_port_cmd,
        "remote-port <1-65535>",
-       "TCP Port number of the Cell Broadcast Centre (Default: 48049)\n"
-       "TCP Port number of the Cell Broadcast Centre (Default: 48049)\n")
+       CBSP_REMOTE
+       "TCP Port number of the remote Cell Broadcast Centre (Default: 
48049)\n")
 {
        struct bsc_cbc_link *cbc = vty_cbc_data(vty);
        cbc->config.cbc_port = atoi(argv[0]);
        return CMD_SUCCESS;
 }

+#define CBSP_LISTEN "Configure OsmoBSC as CBSP server towards a Cell Broadcast 
Centre (inbound TCP connection)\n"
+
 DEFUN(cfg_cbc_listen_port, cfg_cbc_listen_port_cmd,
        "listen-port <1-65535>",
-       "Local TCP port at which BSC listens for incoming CBSP connections from 
CBC\n"
+       CBSP_LISTEN
        "Local TCP port at which BSC listens for incoming CBSP connections from 
CBC\n")
 {
        struct bsc_cbc_link *cbc = vty_cbc_data(vty);
@@ -350,8 +353,8 @@

 DEFUN(cfg_cbc_listen_ip, cfg_cbc_listen_ip_cmd,
        "listen-ip A.B.C.D",
-       "Local IP Address where BSC listens for incoming CBC connections 
(Default: 0.0.0.0)\n"
-       "Local IP Address where BSC listens for incoming CBC connections\n")
+       CBSP_LISTEN
+       "Local IP Address where BSC listens for incoming CBC connections 
(Default: 0.0.0.0)\n")
 {
        struct bsc_cbc_link *cbc = vty_cbc_data(vty);
        osmo_talloc_replace_string(cbc, &cbc->config.listen_hostname, argv[0]);

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19832
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I434835ae8dad9e726f296e648b1b55fb00be8ccb
Gerrit-Change-Number: 19832
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-MessageType: newchange

Reply via email to