pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19832 )
Change subject: CBC VTY: tweak VTY doc strings ...................................................................... Patch Set 1: Code-Review+1 TBH, I find the VTY cmds for this section a bit weird (I know it's not directly related to this commit). IMHO there should be a "local-ip" and "remote-ip" which can always be set. First is used to bind (+listen on server mode), second to connect (or to limit who connects to it in server mode). Same goes for "port", which should be "local-port". There should then be a separate cmd to configure the service to be either a server or a client. With the way it is done right now, it seems that if one uses it as a client, it is impossible to bind to a specific address. That being said, OK with this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19832 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I434835ae8dad9e726f296e648b1b55fb00be8ccb Gerrit-Change-Number: 19832 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2020 16:29:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
