dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19711 )
Change subject: mgcp_e1: remove unused struct member trunk->e1.line ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+1 > > We do huge amounts of object lookups in long llists all over the osmocom > source trees. > Caching the e1.line seems a premature optimization. > > Instead we should do some profiling, and the result will most likely point at > other places that take a lot longer than getting an object from a list of one > member. (In general, I assume osmocom needs to introduce hashmaps at some > point, to look up conn ids on various interfaces instead of iterating every > time) I have checked the context of this patch. In this case e1.line is only needed during initialization. Caching it is pointless since it is not needed anymore after that. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Id4ff52285917ce3885b8dad3a16270999c9da0aa Gerrit-Change-Number: 19711 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 31 Aug 2020 14:24:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
