pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19830 )
Change subject: bts-trx: Ensure RFMUTE state is set properly at startup ...................................................................... Patch Set 1: I did test that osmo-bts-trx continues working fine if the command is rejected, as expected (since in that case anyway we drop the tx power to -10dBm as a poor man solution to mute). I would expect TRX implementations to keep working if a command is not found, but that's really up to the owner of the implementation. If needed we can always add a VTY command to disable it, but given that implementing a fake handler for it (ack it but do nothing) is 5 minutes work, I think we can go forward and add the VTY command later if needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19830 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I96b64cdc901d6f216df628d7be57a67af4a21e25 Gerrit-Change-Number: 19830 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 31 Aug 2020 15:57:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
