pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/19419 )
Change subject: pcuif_proto: version 0xa: add support for NSVC IPv6 support ...................................................................... Patch Set 2: Code-Review-1 I'm sorry but I'm really disliking the use of IPPROTO here, it makes no sense to use it here (since the define is about IP over IP), it's confusing and using those instead of defining them in the protocol header makes the protocol depend on some header for no good reason. Either use AF_INET(6) which can be passed nicely over a unix socket, or define our own PCU protocol defines for PROTO_IPv4 and PROTO_IPv6. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If26958d5b584973dca79159cf9e7f3f266519ce9 Gerrit-Change-Number: 19419 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Assignee: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 07 Sep 2020 08:26:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
