fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19570 )
Change subject: library/PCUIF_Types: version 10: do not add redundant padding ...................................................................... Patch Set 3: Hi Harald, > Patch Set 3: > > why is it redundant? It was originally added to make sure the messages are > the same length as when sent by the C implementation. the problem is that padding makes ENCDEC messages unreadable in the logs generated by ttcn3-pcu-test. Sometimes it's useful to look at raw binary PDU before decoding / after decoding, and with the recent changes you would need to locate a ~8 octets long payload in >700 octets. Given that osmo-pcu does not require a message to be exactly N octets long, I think it's safe not to add padding at all. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19570 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a532d7abff8af354e40c5d706bb882efc6f905f Gerrit-Change-Number: 19570 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Fri, 11 Sep 2020 12:24:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
