lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19417 )
Change subject: Gb: add a second NS implementation ...................................................................... Patch Set 29: (8 comments) I think I've implemented all the requested review. It's still not perfect, but I think we should go for a merge. https://gerrit.osmocom.org/c/libosmocore/+/19417/24/src/gb/gprs_ns2.c File src/gb/gprs_ns2.c: https://gerrit.osmocom.org/c/libosmocore/+/19417/24/src/gb/gprs_ns2.c@346 PS24, Line 346: llist_add(&nsvc->list, &nse->nsvc); > Ack Done https://gerrit.osmocom.org/c/libosmocore/+/19417/24/src/gb/gprs_ns2.c@882 PS24, Line 882: static bool gprs_fsm_vc_registered = false; > I think we usually use constructors to register GFSM and all that. No strong > opinion though. Done https://gerrit.osmocom.org/c/libosmocore/+/19417/24/src/gb/gprs_ns2_internal.h File src/gb/gprs_ns2_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/19417/24/src/gb/gprs_ns2_internal.h@222 PS24, Line 222: static inline int ns2_is_sns(uint8_t pdu_type) > Unused function Done https://gerrit.osmocom.org/c/libosmocore/+/19417/24/src/gb/gprs_ns2_internal.h@222 PS24, Line 222: static inline int ns2_is_sns(uint8_t pdu_type) > Unused function Done https://gerrit.osmocom.org/c/libosmocore/+/19417/24/src/gb/gprs_ns2_internal.h@227 PS24, Line 227: static inline int ns2_is_ns(uint8_t pdu_type) > Unused Done https://gerrit.osmocom.org/c/libosmocore/+/19417/24/src/gb/gprs_ns2_internal.h@227 PS24, Line 227: static inline int ns2_is_ns(uint8_t pdu_type) > Unused Done https://gerrit.osmocom.org/c/libosmocore/+/19417/24/src/gb/gprs_ns2_message.c File src/gb/gprs_ns2_message.c: https://gerrit.osmocom.org/c/libosmocore/+/19417/24/src/gb/gprs_ns2_message.c@43 PS24, Line 43: #define ERR_IF_NSVC_USES_SNS(nsvc, reason) \ > i'll remove this I've implemented the macro as it meant. https://gerrit.osmocom.org/c/libosmocore/+/19417/24/src/gb/gprs_ns2_message.c@64 PS24, Line 64: int gprs_ns2_validate_reset(struct gprs_ns2_vc *nsvc, struct msgb *msg, struct tlv_parsed *tp, uint8_t *cause) > If 0 means success and 1 error, usually we return negative values. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3525beef205588dfab9d3880a34115f1a2676e48 Gerrit-Change-Number: 19417 Gerrit-PatchSet: 29 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Assignee: daniel <dan...@totalueberwachung.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-CC: daniel <dan...@totalueberwachung.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 11 Sep 2020 17:17:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: daniel <dwillm...@sysmocom.de> Gerrit-MessageType: comment
