Hoernchen has submitted this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/20205 )
Change subject: arch: x86: Fix convolve optimizations breaking signal
......................................................................
arch: x86: Fix convolve optimizations breaking signal
This patch fixes MS failing to even see the network, and only RACHs of 1
zeroed byte being seen in GSMTAP.
The issue seems to only appear on some specific machines; others have
been running fine for weeks without this memset being an issue.
Fixes: 7a52e42ee0676f47e801dd348b478302de5d2e50
Change-Id: I98ad885a5d71e7775973a4d881c0f1cd665ea711
---
M Transceiver52M/arch/x86/convolve.c
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
Hoernchen: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/Transceiver52M/arch/x86/convolve.c
b/Transceiver52M/arch/x86/convolve.c
index 81ea782..be62721 100644
--- a/Transceiver52M/arch/x86/convolve.c
+++ b/Transceiver52M/arch/x86/convolve.c
@@ -102,9 +102,9 @@
#ifndef __OPTIMIZE__
if (bounds_check(x_len, h_len, y_len, start, len) < 0)
return -1;
-
- memset(y, 0, len * 2 * sizeof(float));
#endif
+ memset(y, 0, len * 2 * sizeof(float));
+
switch (h_len) {
case 4:
c.conv_real4(x, x_len, h, h_len, y, y_len, start, len);
@@ -142,9 +142,9 @@
#ifndef __OPTIMIZE__
if (bounds_check(x_len, h_len, y_len, start, len) < 0)
return -1;
-
- memset(y, 0, len * 2 * sizeof(float));
#endif
+ memset(y, 0, len * 2 * sizeof(float));
+
if (!(h_len % 8))
c.conv_cmplx_8n(x, x_len, h, h_len, y, y_len, start, len);
else if (!(h_len % 4))
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20205
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I98ad885a5d71e7775973a4d881c0f1cd665ea711
Gerrit-Change-Number: 20205
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
