neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/20357 )
Change subject: LCS: implement the bulk of Location Services ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_loc_req.h File include/osmocom/bsc/lcs_loc_req.h: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_loc_req.h@8 PS1, Line 8: LOGPFSML(LOC_REQ->fi, level, fmt, ## args); \ > missing () around LOC_REQ ack https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_ta_req.h File include/osmocom/bsc/lcs_ta_req.h: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/include/osmocom/bsc/lcs_ta_req.h@11 PS1, Line 11: LOGPFSML(TA_REQ->fi, level, fmt, ## args); \ > () ack https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c File src/osmo-bsc/lb.c: https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c@49 PS1, Line 49: // TODO use > what about this? it's mentioned in the SYS# issue for this. the tests work fine without the BSC sending a RESET, but for practical operation the BSC should RESET to the SMLC, which will follow in another patch https://gerrit.osmocom.org/c/osmo-bsc/+/20357/1/src/osmo-bsc/lb.c@653 PS1, Line 653: "serving mobile location centre", > caps at start of word? i took this style from another ctrg_desc, see bsc_ctrg_desc -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/20357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I28314ba97df86a118497e9b2770e2e6e2484e872 Gerrit-Change-Number: 20357 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 01 Oct 2020 14:37:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
