dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/20319 )
Change subject: vty: add attributes to VTY commands indicating when they apply ...................................................................... Patch Set 3: (2 comments) > Patch Set 3: Code-Review+1 > > I don't have CR+2 capabilities, would do that otherwise. I also do not have them, maybe this is due to the recent gerrit update? https://gerrit.osmocom.org/c/osmo-trx/+/20319/1/CommonLibs/trx_vty.c File CommonLibs/trx_vty.c: https://gerrit.osmocom.org/c/osmo-trx/+/20319/1/CommonLibs/trx_vty.c@101 PS1, Line 101: trx > It's a regular node selection, it does not change any parameters => we don't > need any attributes her […] Ack https://gerrit.osmocom.org/c/osmo-trx/+/20319/1/CommonLibs/trx_vty.c@487 PS1, Line 487: chan <0-100> > This one applies on full program restart => we don't need any attributes here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/20319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6dfdedc081eb8c3d53913f6fa38591920c8b3b43 Gerrit-Change-Number: 20319 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 08 Oct 2020 18:38:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy <[email protected]> Gerrit-MessageType: comment
