laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/20470 )
Change subject: initial working osmo-smlc implementation ...................................................................... Patch Set 6: (4 comments) https://gerrit.osmocom.org/c/osmo-smlc/+/20470/6/include/osmocom/smlc/sccp_lb_inst.h File include/osmocom/smlc/sccp_lb_inst.h: https://gerrit.osmocom.org/c/osmo-smlc/+/20470/6/include/osmocom/smlc/sccp_lb_inst.h@52 PS6, Line 52: Compatibility with legacy osmo-hnbgw that was unable to properly handle RESET messages. Set to 'false' to : * require proper RESET procedures, set to 'true' to implicitly put a lb_peer in RAN_PEER_ST_READY upon the : * first CO message. Default is false = be strict. */ we are not talking to osmo-hnbgw. Do we need that kind of workaround? If yes, we shouldn't refer to osmo-hnbgw here, at least. https://gerrit.osmocom.org/c/osmo-smlc/+/20470/6/src/osmo-smlc/cell_locations.c File src/osmo-smlc/cell_locations.c: https://gerrit.osmocom.org/c/osmo-smlc/+/20470/6/src/osmo-smlc/cell_locations.c@248 PS6, Line 248: unidirectional You probably mean omnidirectional here. "unidirectional" would be the opposite. https://gerrit.osmocom.org/c/osmo-smlc/+/20470/6/src/osmo-smlc/lb_peer.c File src/osmo-smlc/lb_peer.c: https://gerrit.osmocom.org/c/osmo-smlc/+/20470/6/src/osmo-smlc/lb_peer.c@463 PS6, Line 463: " Dropping message.\n"); is there some kind of STATUS we should return to the peer? https://gerrit.osmocom.org/c/osmo-smlc/+/20470/6/src/osmo-smlc/smlc_loc_req.c File src/osmo-smlc/smlc_loc_req.c: https://gerrit.osmocom.org/c/osmo-smlc/+/20470/6/src/osmo-smlc/smlc_loc_req.c@68 PS6, Line 68: smlc_loc_req_fail > Why not to use a function here? I guess compiler would most likely inline it > anyway. I guess because of the "args ..." part. you'd hve to deal with varargs in the function, which in turn menas you cannot use normal logging macros, ...? -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/20470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I917ba8fc51a1f1150be77ae01e12a7b16a853052 Gerrit-Change-Number: 20470 Gerrit-PatchSet: 6 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Sun, 11 Oct 2020 08:30:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy <[email protected]> Gerrit-MessageType: comment
