pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20936 )
Change subject: tbf_dl: Don't fake EGPRS MS class when no related info is available ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/20936/3/src/tbf_dl.cpp File src/tbf_dl.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/20936/3/src/tbf_dl.cpp@a134 PS3, Line 134: LOGP(DTBF, LOGL_NOTICE, "Not accepting non-EGPRS phone in EGPRS-only mode\n"); : bts->bts->do_rate_ctr_inc(CTR_TBF_FAILED_EGPRS_ONLY); : return NULL; > i think this error message and the rate counter are still applicable. […] Because this constraint in this code path makes no sense at the moment we support both EGPRS and GPRS MS, we simply allocated GPRS/EGPRS TBF based on MS class support. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Icce66cadb51af25ae0c3b3719940eccb548fe33b Gerrit-Change-Number: 20936 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Mon, 02 Nov 2020 15:11:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
