pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984 )
Change subject: pcu: prepare tests for new GPRS/EGPRS multiplex support ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984/1/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984/1/pcu/PCU_Tests.ttcn@70 PS1, Line 70: c_PCUIF_Flags_default > Most of the existing test cases are for GPRS, not EGPRS at the moment. […] The usual way of operation is going to be to support both GPRS and EGPRS concurrently, so I want to keep that the default. Passing c_PCUIF_Flags_noMCS to most tests is needed in order to avoid breakage with older versions of osmo-pcu (with "egprs only" flag) which will reject one phase RACH requests. So in fact with newer version of osmo-pcu, most of the test wouldn't care about using _default or not, but I need to keep those for a while to have -latest happy. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib95aae155b0712313a30f0c5404a8cb1f28b98f5 Gerrit-Change-Number: 20984 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Mon, 02 Nov 2020 17:10:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
