laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20929 )
Change subject: pdch: Drop error log line about egprs not enabled ...................................................................... Patch Set 5: it's not just dropping the log line, but also continues processing such blocks, so the log line is misleading. Also, as I stated in the previous review comment, it is less about what the MS sends, but more bout what the TRX/BTS UL PHY/receiver was able to decode+receive. If it has successfully decoded something, we should process it. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie70ec8e4a2d688762d7d320d6ad58d5a0cc52ea1 Gerrit-Change-Number: 20929 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Comment-Date: Mon, 02 Nov 2020 17:27:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
