fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21014 )
Change subject: l1sap: add repeated downlink FACCH ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/21014/2/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/21014/2/src/common/l1sap.c@925 PS2, Line 925: fn + 8 <= fn > The spec says: 3GPP TS 44.006, section 10. […] As we all know, TDMA clock wraps around every 26 * 51 * 2048 frames. Imagine that msg.fn is somewhere near the end of period, while the current fn has already wrapped, for example: msg.fn is (26 * 51 * 2048) - 8 => 2715640, msg.fn + 8 is actually 0, so 2715640 <= 0 would never be true. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72f0cf7eaaef9f80fc35e752c90ae0e2d24d0c75 Gerrit-Change-Number: 21014 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Tue, 10 Nov 2020 22:26:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
