fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21014 )
Change subject: l1sap: add repeated downlink FACCH ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/21014/5/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/21014/5/src/common/l1sap.c@932 PS5, Line 932: 2715648 > I'm sure we have some proper defines or macros related to that and we should > not resort to magic num […] Indeed, I even mentioned them in my previous comments. This: (msg.fn + 8) % 2715648 <= fn could be done with: GSM_TDMA_FN_SUM(msg.fn, 8) <= fn. Or the whole condition can be rewritten (not sure, please re-check): GSM_TDMA_FN_SUB(fn, msg.fn) >= 8. The last variant looks cleaner and closer to what the specs. require to me. https://gerrit.osmocom.org/c/osmo-bts/+/21014/5/src/common/vty.c File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/21014/5/src/common/vty.c@805 PS5, Line 805: "facch-repetition", > why would we ant to have a configuration item for that in the BTS? Shouldn't > it be the policy of th […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72f0cf7eaaef9f80fc35e752c90ae0e2d24d0c75 Gerrit-Change-Number: 21014 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Thu, 12 Nov 2020 02:52:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
