neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21077 )
Change subject: log: rsl_rx_chan_activ: show chan type as human readable string ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/21077/1/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/21077/1/src/common/rsl.c@1265 PS1, Line 1265: type, get_value_string(rsl_act_type_names, type), > Does it make sense to drop the type=0x%02x ? Or isn't the string enough? It > should print the value a […] i was aiming to not annoy people that might be accustomed to the type numbers in the logs... but for me, the string would suffice indeed. (like i am currently super annoyed by some firefox UI changes that make perfect sense to some developer but are just messing up my muscle memory N times a day) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21077 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3acf6c18309d3b4093dbc295be622363cb6dbcdc Gerrit-Change-Number: 21077 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 17 Nov 2020 16:09:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
