pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21204 )
Change subject: hodec 2: favor moving dyn TS ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21204/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/21204/4//COMMIT_MSG@23 PS4, Line 23: Among lchans on dynamic timeslots that could be moved, this code favors moving : later lchans; mainly because it makes for a simpler condition in the code. > here I'm not completely against it, but I'm not sure this is a really good reason... So if I understand correctly, from time to time you end up moving calls from a dyn ts to another in the same TRX (with no real gain doing so?) simply because the code is easier? I'm not sure this convinces me... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic221b8d2687cdec0bf94410c84a4da43853f0900 Gerrit-Change-Number: 21204 Gerrit-PatchSet: 4 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 17 Nov 2020 17:10:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Gerrit-MessageType: comment
