neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21164 )
Change subject: bts: add repeated acch mode flags + vty config ...................................................................... Patch Set 4: (4 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3//COMMIT_MSG@10 PS3, Line 10: a one byte flag is sent this patch does not send anything, all i can see is an unused vty config option. please hint at the patch where this has functional effects https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/include/osmocom/bsc/bts.h File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/include/osmocom/bsc/bts.h@485 PS3, Line 485: struct abis_rsl_osmo_rep_acch_cap repeated_acch_capability_bts; (this is a member of struct gsm_bts, redundant to also name the member *_bts) https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/src/osmo-bsc/bsc_vty.c@2646 PS3, Line 2646: vty_out(vty, "%% repeated ACCH not supported by this BTS%s", would be good to add the BTS number: during program startup, you'd read a lone "this BTS" and wouldn't know which one. Same below. https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/src/osmo-bsc/bsc_vty.c@2651 PS3, Line 2651: if (argv[0][0] == 'c') { i also did it like this some years back and got the code review that i should rather use a strcmp() -- doing that ever since. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190 Gerrit-Change-Number: 21164 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 17 Nov 2020 22:28:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
