neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21204 )
Change subject: hodec 2: favor moving dyn TS ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21204/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/21204/4//COMMIT_MSG@23 PS4, Line 23: Among lchans on dynamic timeslots that could be moved, this code favors moving : later lchans; mainly because it makes for a simpler condition in the code. > I'm not completely against it, but I'm not sure this is a really good > reason... […] sorry but you clearly are missing the point here :) The question in this condition is not whether a dyn TS is moved or not, the question is *which one* do you pick. So if there are a choice of N dyn TS with identical ratings, it does not matter which one you pick to be handed over, all of those with the same avg_db are identically qualified candidates. I have no strong argument to pick the last one, equally you have no strong argument for picking the first one. The decision to move an lchan of that type is taken elsewhere, and there is a real gain doing so, and that decision is made orthogonally to finding an lchan matching that decision here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic221b8d2687cdec0bf94410c84a4da43853f0900 Gerrit-Change-Number: 21204 Gerrit-PatchSet: 4 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 17 Nov 2020 23:26:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
