pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21164 )
Change subject: bts: add repeated acch mode flags + vty config ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/21164/5/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21164/5/src/osmo-bsc/bsc_vty.c@1121 PS5, Line 1121: vty_out(vty, " repeat dl-facch cmd%s", VTY_NEWLINE); typo: cmd -> command https://gerrit.osmocom.org/c/osmo-bsc/+/21164/5/src/osmo-bsc/bsc_vty.c@2652 PS5, Line 2652: bts->repeated_acch_capability_bts.dl_facch_cmd = 1; All these are basically booleans, so better use true/false. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190 Gerrit-Change-Number: 21164 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Thu, 19 Nov 2020 11:59:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
