laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21164 )
Change subject: bts: add repeated acch mode flags + vty config ...................................................................... Patch Set 6: -Code-Review (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21164/6/include/osmocom/bsc/bts.h File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/21164/6/include/osmocom/bsc/bts.h@485 PS6, Line 485: repeated_acch_capability_bts what is a bit uncleaer to me is what exactly we are configuring here. Is the user expected to confiure that his BTS is capable of supporting those features? In that case, this should be automatically detected based on feature flags at OML startup. Is the user expected to confgure a policy, i.e. that the BSC is permitted to use those feautres if a) the BTS is capable and b) the MS is capable? The fact that the variable is called "capability_bts" seems to indicate that you are configuring what the BTS is capable of doing. And that's really something the user shouldn't have to know. Capabilities of the BTS are reported at OML startup. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190 Gerrit-Change-Number: 21164 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Comment-Date: Fri, 20 Nov 2020 09:02:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
