lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21243 )
Change subject: ns2: add support for frame relay ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c File src/gb/frame_relay.c: https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/frame_relay.c@343 PS1, Line 343: /* TODO: implement FRNET free */ > sounds like leaking memory? it's complicated ;D. See the new big comment. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_fr.c File src/gb/gprs_ns2_fr.c: https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_fr.c@301 PS1, Line 301: /* FIXME half writes */ > yes, indeed. An osmo_wqueue is probably the best approach. […] I would like to do the wqueue on top as seperate commit. https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_vty.c File src/gb/gprs_ns2_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/21243/1/src/gb/gprs_ns2_vty.c@484 PS1, Line 484: uint16_t dlci = atoi(argv[2]); > I'm still unsure if I want this in the change. I've fixed the missing nsvci. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id3b49f93d33c271f77cd9c9db03cde6b727a4d30 Gerrit-Change-Number: 21243 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Tue, 24 Nov 2020 03:12:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]> Gerrit-MessageType: comment
